fix: ContainerTransferTask crash when transferring 0-count selection#292
Open
we-02 wants to merge 1 commit into
Open
fix: ContainerTransferTask crash when transferring 0-count selection#292we-02 wants to merge 1 commit into
we-02 wants to merge 1 commit into
Conversation
BreakSim creates a StackSelection with count=0 to represent an empty
hand being acceptable. When the build engine resolved a WrongItemSelection
result with this selection, it unconditionally called transferByTask,
spawning a ContainerTransferTask that tried to move 0 items out of a
shulker box which always failed with NoMaterialAccessException.
Two fixes:
- GenericResult.WrongItemSelection.resolve(): skip the transfer when
count == 0, since nothing needs to be acquired.
- ContainerTransferTask.checkFail(): was calling failure() unconditionally
via �lso {}, making failIfNoMaterial only affect the (unused) return
value. Now correctly calls failure() only when failIfNoMaterial is true,
and success() otherwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #226